Approve intentional SciMLBase reexports in QA#1106
Merged
ChrisRackauckas merged 1 commit intoJul 22, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Commit d9a1735 adds the focused approval for the intentional SciMLBase facade reexports. Local verification: Julia 1.12 |
ChrisRackauckas
marked this pull request as ready for review
July 22, 2026 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Please ignore this PR until it has been reviewed by @ChrisRackauckas.
Summary
@reexport using SciMLBaseRegression analysis
GROUP=QApasses at parent commit d4786f9 and starts failing at 6e50f19 (#1096), where the SciMLTesting 2.x upgrade enabled public-reexport QA. Current main reports all 185 intentional SciMLBase facade names becausescimlbase_reexportswas only supplied torendered_ignore, notreexports_allow.Local verification
GROUP=QA julia +1.12 --startup-file=no --project=. -e "using Pkg; Pkg.test()"— passed: Quality Assurance 20 passed / 2 broken; JET 28 passed / 7 broken--check .— passedgit diff --check— passedProcess
Reproduced on a clean main worktree, compared the introducing commit with its passing parent, inspected SciMLTesting 2.4.0 reexport-check semantics, and applied the smallest configuration-only correction.